Skip to content

fix(ebean-dao): move SharedSchemaCache pre-warm to EbeanLocalAccess c… #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ybz1013 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ebean-dao): move SharedSchemaCache pre-warm to EbeanLocalAccess c… #619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions dao-impl/ebean-dao/src/main/java/com/linkedin/metadata/dao/EbeanLocalAccess.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ public EbeanLocalAccess(EbeanServer server, ServerConfig serverConfig, @Nonnull
_schemaEvolutionManager = createSchemaEvolutionManager(serverConfig);
_nonDollarVirtualColumnsEnabled = nonDollarVirtualColumnsEnabled;
validator = buildValidator(server, serverConfig);
// Pre-warm at construction time so the cache is hot before the first request,
// regardless of whether ensureSchemaUpToDate() is called by the service.
validator.registerAndPreWarm(getTableName(_entityType));
validator.registerAndPreWarm(getTestTableName(_entityType));
}

private static SchemaValidatorUtil buildValidator(EbeanServer server, ServerConfig serverConfig) {
Expand Down Expand Up @@ -135,9 +139,6 @@ public void configureOptionalForceIndex(@Nullable String indexName,

public void ensureSchemaUpToDate() {
_schemaEvolutionManager.ensureSchemaUpToDate();
// Pre-warm the shared cache for both the prod and test tables so the first request is never slow.
validator.registerAndPreWarm(getTableName(_entityType));
validator.registerAndPreWarm(getTestTableName(_entityType));
validateForceIndex();
}

Expand Down
Loading