Skip to content

Conversation

@pthirun
Copy link
Contributor

@pthirun pthirun commented Jan 28, 2026

Summary

  • Migrate the GET_BACKUP_VERSION HTTP endpoint to gRPC
  • Add GetBackupVersionGrpcRequest and GetBackupVersionGrpcResponse proto messages
  • Add getBackupVersion RPC to VeniceControllerGrpcService
  • Refactor StoresRoutes.getBackupVersion() to use the shared request handler
  • Add VeniceNoStoreException handling in ControllerGrpcServerUtils for NOT_FOUND status
  • Add comprehensive tests for the handler and gRPC service

Test plan

  • Unit tests for VeniceControllerRequestHandler.getBackupVersion() (parent and child controller scenarios)
  • Unit tests for VeniceControllerGrpcServiceImpl.getBackupVersion() (success and error cases)
  • Unit tests for StoresRoutes.getBackupVersion() (HTTP route integration)
  • All existing tests pass

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant