feat(http/prom): introduce StreamLabel components
#4251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit introduces a collection of `MkStreamLabel` and `StreamLabel` implementations that can be used to inspect status codes for HTTP and gRPC traffic. these do not emit duration labels, but can be used by other implementors of these traits to perform the common logic of checking HTTP status codes in response front matter, and for inspecting body trailers in gRPC traffic. Signed-off-by: katelyn martin <[email protected]>
this commit introduces a `LabelError<E>` type, which provides a `StreamLabel` implementation that maps boxed errors to labels. this is generic across `E`-typed labels that can be constructed `From` a reference to a boxed `linkerd_error::Error`. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/http-prom.stream-label-components
branch
from
aac9f88 to
c8d28a6
Compare
cratelyn
changed the title
StreamLabel components
This was referenced Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nb: this branch is based upon #4250.
feat(http/prom): add http and grpc status labelers
this commit introduces a collection of
MkStreamLabelandStreamLabelimplementations that can be used to inspect status codes for HTTP and
gRPC traffic.
these do not emit duration labels, but can be used by other
implementors of these traits to perform the common logic of checking
HTTP status codes in response front matter, and for inspecting body
trailers in gRPC traffic.
feat(http/prom): add an error labeler
this commit introduces a
LabelError<E>type, which provides aStreamLabelimplementation that maps boxed errors to labels.this is generic across
E-typed labels that can be constructedFromareference to a boxed
linkerd_error::Error.