Skip to content

Conversation

@ad-astra-video
Copy link
Collaborator

What does this pull request do? Explain your changes. (required)

Want to extend default timeout on stop requests to 60 seconds to allow for cleanup.

In my video data app I have a number of LLM calls that would like to be able to have some time to wrap up to get all data.

May want to consider making this configurable in the future but 60 seconds seems reasonable and can always go much faster than that.

Specific updates (required)

  • changes stop timeout from 10 seconds to 60 seconds
  • updates tests to accomodate

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@github-actions github-actions bot added the go Pull requests that update Go code label Jan 26, 2026
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.24436%. Comparing base (1a26807) to head (9a2e95f).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              master       #3861   +/-   ##
=============================================
  Coverage   32.24436%   32.24436%           
=============================================
  Files            169         169           
  Lines          41201       41201           
=============================================
  Hits           13285       13285           
  Misses         26915       26915           
  Partials        1001        1001           
Files with missing lines Coverage Δ
byoc/stream_gateway.go 57.65379% <100.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a26807...9a2e95f. Read the comment docs.

Files with missing lines Coverage Δ
byoc/stream_gateway.go 57.65379% <100.00000%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@eliteprox eliteprox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a quick solution. Extending the timeouts can cause to "stuck capacity", IIRC.

For the backlog, I'd recommend to send a control message with timeout and let the worker (pytrickle) cleanup frame_processor tasks async. Then, /stop can return immediately and the worker can signal to the gateway to close trickle channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants