Skip to content

BYOC: Longer byoc stream stop timeout #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ad-astra-video wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −8
Open

BYOC: Longer byoc stream stop timeout #3861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86de9bd
update stop request to be 60s timeout
ad-astra-video Jan 22, 2026
9a2e95f
update tests
ad-astra-video Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion byoc/stream_gateway.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ func (bsg *BYOCGatewayServer) sendStopStreamToOrch(ctx context.Context, streamID
Req: &JobRequest{
Capability: capability,
Request: string(jobReqDetStr),
Timeout: 10,
Timeout: 60,
},
},
node: bsg.node,
Expand Down
14 changes: 7 additions & 7 deletions byoc/stream_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ func TestRunStream_RunAndCancelStream(t *testing.T) {
jobReq := &JobRequest{
ID: "test-stream",
Capability: "test-capability",
Timeout: 10,
Timeout: 60,
Request: "{}",
}
jobParams := JobParameters{EnableVideoIngress: true, EnableVideoEgress: true, EnableDataOutput: true}
Expand All @@ -458,7 +458,7 @@ func TestRunStream_RunAndCancelStream(t *testing.T) {
drivers.NodeStorage = drivers.NewMemoryDriver(nil)
mockSender := pm.MockSender{}
mockSender.On("StartSession", mock.Anything).Return("foo").Times(4)
mockSender.On("CreateTicketBatch", "foo", 10).Return(mockTicketBatch(10), nil).Twice() //payment sent on start and stop (only once on stop)
mockSender.On("CreateTicketBatch", "foo", 60).Return(mockTicketBatch(60), nil).Twice() //payment sent on start and stop (only once on stop)
node.Sender = &mockSender
node.Balances = core.NewAddressBalances(10 * time.Second)
defer node.Balances.StopCleanup()
Expand Down Expand Up @@ -614,7 +614,7 @@ func TestRunStream_OrchestratorFailover(t *testing.T) {
jobReq := &JobRequest{
ID: "test-stream",
Capability: "test-capability",
Timeout: 10,
Timeout: 60,
Request: "{}",
}
jobParams := JobParameters{EnableVideoIngress: true, EnableVideoEgress: true, EnableDataOutput: true}
Expand Down Expand Up @@ -835,7 +835,7 @@ func TestStopStreamHandler(t *testing.T) {
drivers.NodeStorage = drivers.NewMemoryDriver(nil)
mockSender := pm.MockSender{}
mockSender.On("StartSession", mock.Anything).Return("foo").Times(4)
mockSender.On("CreateTicketBatch", "foo", 10).Return(mockTicketBatch(10), nil).Once()
mockSender.On("CreateTicketBatch", "foo", 60).Return(mockTicketBatch(60), nil).Once()
node.Sender = &mockSender
node.Balances = core.NewAddressBalances(10 * time.Second)
defer node.Balances.StopCleanup()
Expand Down Expand Up @@ -874,7 +874,7 @@ func TestStopStreamHandler(t *testing.T) {
Request: marshalToString(t, jobDetails),
Capability: "test-capability",
Parameters: marshalToString(t, jobParams),
Timeout: 10,
Timeout: 60,
}
jobReqB, err := json.Marshal(jobReq)
assert.NoError(t, err)
Expand Down Expand Up @@ -923,7 +923,7 @@ func TestStopStreamHandler(t *testing.T) {
drivers.NodeStorage = drivers.NewMemoryDriver(nil)
mockSender := pm.MockSender{}
mockSender.On("StartSession", mock.Anything).Return("foo").Times(4)
mockSender.On("CreateTicketBatch", "foo", 10).Return(mockTicketBatch(10), nil).Once()
mockSender.On("CreateTicketBatch", "foo", 60).Return(mockTicketBatch(60), nil).Once()
node.Sender = &mockSender
node.Balances = core.NewAddressBalances(10 * time.Second)
defer node.Balances.StopCleanup()
Expand Down Expand Up @@ -956,7 +956,7 @@ func TestStopStreamHandler(t *testing.T) {
Request: marshalToString(t, jobDetails),
Capability: "test-capability",
Parameters: marshalToString(t, jobParams),
Timeout: 10,
Timeout: 60,
}
jobReqB, err := json.Marshal(jobReq)
assert.NoError(t, err)
Expand Down
Loading