Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github] Bump Runner Version in Containers #124324

Merged

Conversation

boomanaiden154
Copy link
Contributor

This patch bumps the runner version to v2.322.0 in the CI containers. Nothing looks suspicious in the change log, and it is important to keep the runner up to date or we will end up with containers that cannot connect to Github due to having a version too old.

This patch bumps the runner version to v2.322.0 in the CI containers. Nothing
looks suspicious in the change log, and it is important to keep the runner up
to date or we will end up with containers that cannot connect to Github due
to having a version too old.
@llvmbot
Copy link
Member

llvmbot commented Jan 24, 2025

@llvm/pr-subscribers-github-workflow

Author: Aiden Grossman (boomanaiden154)

Changes

This patch bumps the runner version to v2.322.0 in the CI containers. Nothing looks suspicious in the change log, and it is important to keep the runner up to date or we will end up with containers that cannot connect to Github due to having a version too old.


Full diff: https://github.com/llvm/llvm-project/pull/124324.diff

2 Files Affected:

  • (modified) .github/workflows/containers/github-action-ci-windows/Dockerfile (+1-1)
  • (modified) .github/workflows/containers/github-action-ci/Dockerfile (+1-1)
diff --git a/.github/workflows/containers/github-action-ci-windows/Dockerfile b/.github/workflows/containers/github-action-ci-windows/Dockerfile
index 2295e39d62c30f..9a1fab694c9dfc 100644
--- a/.github/workflows/containers/github-action-ci-windows/Dockerfile
+++ b/.github/workflows/containers/github-action-ci-windows/Dockerfile
@@ -108,7 +108,7 @@ RUN choco install -y handle
 
 RUN pip3 install pywin32 buildbot-worker==2.8.4
 
-ARG RUNNER_VERSION=2.321.0
+ARG RUNNER_VERSION=2.322.0
 ENV RUNNER_VERSION=$RUNNER_VERSION
 
 RUN powershell -Command \
diff --git a/.github/workflows/containers/github-action-ci/Dockerfile b/.github/workflows/containers/github-action-ci/Dockerfile
index 35a0f1f6020dcd..377b8f14402ee0 100644
--- a/.github/workflows/containers/github-action-ci/Dockerfile
+++ b/.github/workflows/containers/github-action-ci/Dockerfile
@@ -96,7 +96,7 @@ WORKDIR /home/gha
 
 FROM ci-container as ci-container-agent
 
-ENV GITHUB_RUNNER_VERSION=2.321.0
+ENV GITHUB_RUNNER_VERSION=2.322.0
 
 RUN mkdir actions-runner && \
     cd actions-runner && \

@lnihlen
Copy link
Contributor

lnihlen commented Jan 24, 2025

I don't want to hold up this PR but it's worth asking the question - is there any way we could set this version in one location, so we don't have two numbers to keep in sync?

@boomanaiden154
Copy link
Contributor Author

is there any way we could set this version in one location, so we don't have two numbers to keep in sync?

It's possible, but would require a bit of refactoring. Opened an issue and assigned it to myself to keep track of this - #124367.

@boomanaiden154 boomanaiden154 merged commit d789915 into llvm:main Jan 24, 2025
12 checks passed
@boomanaiden154 boomanaiden154 deleted the bump-runner-version-2-322-0 branch January 24, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants