chore: sepolia deployment testing multisig upgrade#257
Draft
AuHau wants to merge 1 commit intofeat/upgradable-contractfrom
Draft
chore: sepolia deployment testing multisig upgrade#257AuHau wants to merge 1 commit intofeat/upgradable-contractfrom
AuHau wants to merge 1 commit intofeat/upgradable-contractfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just to showcase the upgrade of the Marketplace contract using a multisig wallet.
I have deployed Safe Multisig Wallet and Marketplace to Sepolia with having the
ProxyAdminassigned to the Safe Multisig and then performed the upgrade.(The difference between the implementations can be seen in the added
newShinyMethod()method)Etherscan nicely shows the upgrades:

The upgrade process is like:
ProxyAdminABI, which then allows easy construction of theupgradeAndCall()call, which switches the implementation in the Proxy contract.If the process will need to be streamlined, then there is a possibility to create a JS/bash script that would propose the upgrading transaction using Safe Transaction Service API: