Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement email notifications #205

Merged
merged 16 commits into from
Aug 26, 2024
Merged

Conversation

fabian-emilius
Copy link
Collaborator

No description provided.

@fabian-emilius fabian-emilius requested a review from krusche August 22, 2024 16:06
@fabian-emilius fabian-emilius self-assigned this Aug 22, 2024
@fabian-emilius fabian-emilius linked an issue Aug 22, 2024 that may be closed by this pull request
@fabian-emilius fabian-emilius marked this pull request as draft August 22, 2024 16:06
Copy link
Member

@krusche krusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to formulate the emails in active voice and avoid passive voice.
Please add a table in the README or documentation to better understand which user groups receive which emails.

…ment-email-notifications

# Conflicts:
#	server/mail-templates/application-created-chair.html
#	server/mail-templates/application-created-student.html
#	server/src/main/java/thesistrack/ls1/entity/TopicRole.java
#	server/src/main/java/thesistrack/ls1/service/ApplicationService.java
#	server/src/main/java/thesistrack/ls1/service/MailingService.java
#	server/src/main/java/thesistrack/ls1/service/ThesisCommentService.java
#	server/src/main/java/thesistrack/ls1/service/ThesisService.java
@fabian-emilius fabian-emilius marked this pull request as ready for review August 26, 2024 20:20
@fabian-emilius fabian-emilius merged commit 814a1bc into main Aug 26, 2024
2 checks passed
@fabian-emilius fabian-emilius deleted the 94-implement-email-notifications branch August 26, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Email Notifications
2 participants