#39641 Replace loop variable name to correct the "cache" effect on subsequent calls on the same $product object

[bhennesAdv]

Hello,

This PR is related to #39641

Description (*)

Change a loop variable name to correctly add the "_cache_instance_product_ids" data on the given product to be used on subsequent calls.

Related Pull Requests

None

Fixed Issues (if relevant)

1. Fixes [\Magento\ConfigurableProduct\Model\Product\Type\Configurable] PHP error unoticed #39641

Manual testing scenarios (*)

Let me know if you need some tests for this change

Questions or comments

None, it's just a variable name change in a deprecated method

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @bhennesAdv. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[ihor-sviziev]

@bhennesAdv, could you please sign Adobe CLA?

[bhennesAdv]

Hello @ihor-sviziev

How should I do that ?

Regards,
Baptiste

[ihor-sviziev]

@bhennesAdv here is the instruction: https://github.com/magento/magento2/pull/39642/checks?check_run_id=37526965741

[bhennesAdv]

@ihor-sviziev Done.

Thank you.

[ihor-sviziev]

@bhennesAdv, thank you for your prompt action!

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

Hello @bhennesAdv

Thank you for contribution & collaboration!

✔️ QA Passed

We have verified the change and it looks good to us. No manual testing is required at this point as it is very clear that $product variable was used by the loop as looping element erasing the given variable.

Builds are failing hence moving this PR to Extended Testing.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Functional Tests B2B, Unit Tests

[engcom-Dash]

Test failures for Functional B2B are inconsistent and seems to be flaky. They neither part of PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39642/24db56311bcbf9f18d51941cb3242530/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39642/95d39af72ad94e1f0ca8d81c38097512/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Hence, moving this PR in Merge In Progress.