-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Add store level to config read #39752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @rikwillems. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @rikwillems,
Thanks for the contribution!
The changes seems good to us. But please fix the failed static and integration tests.
Thanks
@rikwillems Thank you for contribution! |
@engcom-Dash I'm sorry but I cannot see the results of the (failing) tests. Could you have a look? |
@magento run all tests |
Hello @rikwillems this is because I updated a PR branch with latest 2.4-develop. In sometime you will be able to see the results once build is completed. Meanwhile you can have a look at this previous build to analyse the static & integration failure https://github.com/magento/magento2/pull/39752/checks?check_run_id=40648996051. ![]() |
@magento run all tests |
@rikwillems As per our discussion on slack, I have fixed the failing integration & static test cases. @engcom-Hotel Could you please review the code changes ? Thank You! |
Fix #39751