-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
megadriv.xml: Added 3 items (2 working), replaced Bad Dump with verified one, fixed titles, added info #11355
Conversation
Clones added: - Sonic The Hedgehog (World, JP2, ripped from Sonic Mega Collection) - Sonic The Hedgehog 2 (prototype, pirate) Fixed some titles, added some info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What’s your rationale for changing the capritalisation of the titles? Sega’s marketing material stylises it as “SONIC THE HEDGEHOG” and in cases like this we usually use conventional title case.
Example: https://shop.sega.com/collections/shirts/products/sonic-the-hedgehog-april-fools-smear-black-unisex-tee-1
All page content uses all caps “SONIC THE HEDGEHOG” except the page’s actual title element which uses conventional title case “Sonic the Hedgehog…”
Actually, not capitalising it is a modern thing. Up to recent ages, it was an official thing to have Sonic's "The" always capitalised. Al Nilsen even had it registered as Sonic's middle name. |
After more investigation, there’s one occurrence of “Sonic The Hedgehog” in the manual for the first game. The second and third games also use “Sonic The Hedgehog” in manuals. Sonic & Knuckles only uses “Sonic The Hedgehog 2” when referring to the second game, and uses “Knuckles the Echidna”. From Sonic CD onward, manuals all use “Sonic the Hedgehog”. So it seems it’s officially “Sonic The Hedgehog” for the first three games. |
Yes, that's why I added a capital T to those. |
4ee53c6
to
0268ef1
Compare
…nto megadriv-sonics
Fixed conflict due to recent entry addition. |
I still object to adding the defaced prototype dump for the same reason as before. It’s just going to encourage people to withhold clean dumps and only release defaced dumps for street cred. This isn’t some hack that was widely distributed back in the day. It’s a relatively recent dump that’s been defaced by the person who dumped it because they want to draw attention to themselves. Adding it to the software list will ensure the defaced ROM is widely distributed, giving them the attention they’re looking for. This will encourage more people to do the same. |
No, it's not. It's a leaked build from 1992. |
It’s a vanity hack of a leaked 1992 build. Whether it was dumped from a cartridge or obtained some other way is immaterial. It was obtained relatively recently, and only released in a defaced form. Adding it will encourage more people to only release vanity hacks for street cred, increasing the chance that things get hoarded and/or lost. |
Read all about it here: https://hiddenpalace.org/News/What_Was_Once_Old_Is_New_Again |
Replaced fan-made version number, changed one title to what's actually displayed on the Title Screen. Also added "(box)" inside Wacky World's alt_title tag, as in other entries.
…nto megadriv-sonics
This should be ready to merge now. |
I added HeartBeat PGA Tour Golf II myself. There were numerous issues with the way you added it:
I also applied your “Sega Game Toshokan” and “16t” changes as they match branding. There’s too much stuff mixed up in this PR, and all of it needs verification. |
This had already been reviewed and fixed, what are you doing |
So is this in limbo again or what happens now. |
What he said: either fix the conflicts or start over, 6 months (& 5 reviewers) for a XML change that should've split in at least 3 different PRs is far from ideal. |
Since Vas wanted to add it himself.
Wait, I'm the one who has to fix the conflicts that Vas just caused? e4e420b |
The alternative is just outright close this PR myself, what do you choose? |
I choose please help? |
New PR without conflicts here: #12171 |
Not working entry added (for use with the HeartBeat Catalyst fitness sensor):
Bad Dump replaced with verified one:
Clones added:
Fixed descriptions, added info, added entries to lists of missing dumps.
Should contain all the info from the closed PR #11353 in an easier-to-review form (without grouping the Sega Game Toshokan titles into their own section or doing additional cleanups).