Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/emu.lua: Remove redundant "precompile" project #12539

Closed
wants to merge 1 commit into from

Conversation

FlykeSpice
Copy link
Contributor

I dunno why is it there but it doesn't seem to participate in anything besides being a stub.

@cuavas
Copy link
Member

cuavas commented Jul 2, 2024

The precompile target ensures the precompiled prefix header is compiled before the main target is built (you can see the make file for it at e.g. build/projects/windows/mame/gmake-mingw64-gcc/precompile.make for a MinGW GCC build).

@cuavas cuavas closed this Jul 2, 2024
@FlykeSpice
Copy link
Contributor Author

FlykeSpice commented Jul 2, 2024

The precompile target ensures the precompiled prefix header is compiled before the main target is built (you can see the make file for it at e.g. build/projects/windows/mame/gmake-mingw64-gcc/precompile.make for a MinGW GCC build).

Actually, this is automatically ensured by GENie on the generated makefile that the precompiled header must be compiled before sourcefiles that includes/depends on it, otherwise the build system would be broken (Just look at build/projects/.../emu.make which uses precompiled header)

besides the precompiled header must be compiled before the sourcefile that uses it, not before the linking of target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants