-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nmk/nmk16.cpp: upgraded interrupts trigger system based on PROM contents #12562
Conversation
* added info about screen resolutions and timings * merged powerins.cpp into nmk16.cpp driver to make use the new interrupt system
I marked the PR as draft because Additionally: Is the flag |
Powerins bootleg C never worked correctly anyway. It's the electronic devices italy bootleg. The reason the old power instinct driver was based on the bootlegs as it took many years for the original dumps to turn up. |
MACHINE_SUPPORTS_SAVE isn't a default choice by the core, but it should be everyone's default choice when writing/updating a driver :-) |
|
As far as I can see they crash because they don't have the ROM_REGION "vtiming" that the set_interrupt_timing(config); call in their machine_config expects |
Thanks @Osso13 for pointing that. That was a copy/paste error and I wrongly included Fixed now and the PR promoted to Ready |
Is something else needed to be checked or included on this PR? Games were fairly tested with new interrupts system with no noticeable issues. Do you expect me to add or test something else? Additional improvements such applying the new system to Comad games, also in |
set_interrupt_timing()
andnmk16_scanline
.set_hacky_interrupt_timing()
andnmk16_hacky_scanline
handlers.set_screen_xxxxxx()
functions as the screen sizes are confirmed for each available resolutionhachamfp
are added tohachamf
and other clones, and marked asBAD_DUMP
until they are properly dumpedbjtwin
are added tonouryoku
and clones, and marked asBAD_DUMP
until they are properly dumpedstrahl
and clones could benefit from the new interrupt system, but PROMs for them are undumped. They still use the old system until they are properly dumpedssmissin
andairattck
"Comad" games could also benefit from the new interrupt system, but the V-Timing PROM on them is a 82S147 (512x8bit) in which only half of space is used and A5 address line is tied to ground. Thenmk16_scanline
code could be tweaked to support them, but more research is needed to apply that. They still use the old system.powerins.cpp
intonmk16.cpp
driver to make use the new interrupt system, too. Newset_screen_midres()
function is added to be used bypowerins
sets.