igs/igs_fear.cpp: made game playable without sound [XingXing] #12563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HappyASR
commented
Jul 10, 2024
HappyASR
commented
- added timer and interrupt
- added rtc
- add input and dipswitch
- add fipx in sprite drawing
- correct game version of superkids
rb6502
reviewed
Jul 10, 2024
src/mame/igs/igs_fear.cpp
Outdated
|
|
||
| uint32_t screen_update(screen_device &screen, bitmap_ind16 &bitmap, const rectangle &cliprect); | ||
|
|
||
| uint32_t m_gpio_o; |
There was a problem hiding this comment.
We prefer to keep function signatures and variables separate. I usually do all the function stuff and then all the variables, but the other way is fine too if that works better for you. I used to write stuff all mixed together like this and it turns out it wasn't great for maintaining it later.
|
This looks quite good aside from the one thing I pointed out. Get that rearranged and it should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.