nintendo/snesb.cpp: fill in missing DIP switches for several games, add continue counter init for Wild Guns #12565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd continue counter init for Wild Guns
angelosa
approved these changes
Jul 11, 2024
|
Nice work! Great to see these getting some love :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds/verifies the DIP definition for all the SNES bootlegs that had a TODO for them. Defaults are based on the original SNES games, when possible, aside from Wild Guns (the original gives extends at 100k, which isn't an option with this bootleg, so the default is 400k to match current MAME behavior).
Also, Wild Guns now inits the continue counter on boot/reset, which is apparently supposed to be done by whatever's on the other side of the shared RAM. The only times it's initialized by the game itself are when the current counter hits zero or when a second player joins mid-game. I promoted it to working since I didn't encounter any other issues during a full playthrough.