Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machine/ncr5385.cpp: fix timeout #13268

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

machine/ncr5385.cpp: fix timeout #13268

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c91f5f
- dont wait full 250ms if not IDLE
Jan 24, 2025
2fe6461
- PM suggest refactor to always progress
Feb 3, 2025
1df6e27
- requires 40us delay to work
Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/devices/machine/ncr5385.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,16 +169,18 @@ void ncr5385_device::scsi_ctrl_changed()

static char const *const nscsi_phase[] = { "DATA OUT", "DATA IN", "COMMAND", "STATUS", "*", "*", "MESSAGE OUT", "MESSAGE IN" };

if ((ctrl & S_BSY) && !(ctrl & S_SEL))

if (ctrl & S_BSY)
{
LOGMASKED(LOG_STATE, "scsi_ctrl_changed 0x%03x phase %s%s%s\n", ctrl, nscsi_phase[ctrl & S_PHASE_MASK],
ctrl & S_REQ ? " REQ" : "", ctrl & S_ACK ? " ACK" : "");
if (ctrl & S_SEL)
LOGMASKED(LOG_STATE, "scsi_ctrl_changed 0x%03x arbitration/selection\n", ctrl);
else
LOGMASKED(LOG_STATE, "scsi_ctrl_changed 0x%03x phase %s%s%s\n", ctrl, nscsi_phase[ctrl & S_PHASE_MASK],
ctrl & S_REQ ? " REQ" : "", ctrl & S_ACK ? " ACK" : "");

if (m_state != IDLE)
m_state_timer->adjust(attotime::zero);
m_state_timer->adjust(attotime::from_usec(40));
}
else if (ctrl & S_BSY)
LOGMASKED(LOG_STATE, "scsi_ctrl_changed 0x%03x arbitration/selection\n", ctrl);
else
{
LOGMASKED(LOG_STATE, "scsi_ctrl_changed 0x%03x BUS FREE\n", ctrl);
Expand Down
Loading