mingw: use response files to avoid long command lines#15198
Open
pmackinlay wants to merge 1 commit intomamedev:masterfrom
Open
mingw: use response files to avoid long command lines#15198pmackinlay wants to merge 1 commit intomamedev:masterfrom
pmackinlay wants to merge 1 commit intomamedev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After switching to an MSYS configuration using only the CLANG64 environment, I encountered a problem with command lines exceeding a limit of 8192 characters, preventing full builds from completing. GENie has two options allowing the use of response files to avoid this issue, however the current implementation relies on calling an external
echocommand, which trips over the same problem.This PR switches on the GENie response file logic for all MINGW- builds, and patches GENie to use the gmake file function instead of
echo.I think the command line limit may have surfaced when switching from using tools with a cygwin C runtime to UCRT, but I don't have conclusive proof of that yet. This PR may help others in the short term unless a better solution can be found.