swim1.cpp: Set long cell error only when synched - #15764
Open
FakeShemp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was converting some of my DSHD Mac floppies to moof and MFI, but when I tried to run them on a SWIM1 device, like
macse30I got "unreadable disk" errors. Converting the dumps to IMG made them work.I think I figured out the reason, being that the dumps have some slightly too long cell lengths around write splices. There's already a comment in the source about too short ones causing issues, so the "too short" error has been overridden already. These don't happen on perfect timing IMGs as far as I know.
I know way too little about the SWIM to come up with a real fix, but am happy for input if this looks too dumb.