video/mc6847.cpp: remove implicit screen setup default in device_config_complete - #15855
Open
angelosa wants to merge 3 commits into
Open
video/mc6847.cpp: remove implicit screen setup default in device_config_complete#15855angelosa wants to merge 3 commits into
angelosa wants to merge 3 commits into
Conversation
…ig_complete * CRTC video devices are never intended to have this kind of information, screen_device is an abstraction that emulates a monitor connection. * In MC6847 case the device is normally paired with a MC1372 RF modulator. * fix recent regression with trs/coco12.cpp at least (setting a screen of 100x100)
angelosa
commented
Aug 6, 2026
| 456, // htotal | ||
| 0, // hbend | ||
| BMP_L_OR_R_BORDER * 2 + BMP_ACTIVE_VIDEO, // hbstart | ||
| m_tpfs, // vtotal |
Member
Author
There was a problem hiding this comment.
btw m_tpfs is in floating point ...
Member
Author
|
fwiw there are a bunch of other devices that internalizes |
angelosa
commented
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.