Refresh active relay clients after config changes#2
Conversation
|
Warning Review limit reached
Next review available in: 46 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Same-URL relay configuration replacement now restarts the active relay client so rotated authorization tokens take effect without replacing the endpoint or live QUIC connections. Relay removal stops the affected client while retaining the prior advertised home until net-report selects its replacement, avoiding a transient relay-less address.
The regression test uses an auth-enforcing local relay, rotates its expected token, replaces the relay config at the same URL, and verifies token B is observed while endpoint identity, connection stable ID, and a live stream remain intact.
Verification:
cargo test -p iroh --lib -- --test-threads=1(112 passed, 1 ignored)cargo fmt --checkcargo check -p iroh --all-targetscargo clippy -p iroh --all-targets -- -D warningsNeed help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Restart active relay clients when their config is updated at the same URL so rotated auth tokens take effect without changing the endpoint ID or dropping existing QUIC connections. Also fixes cancellation leaks in address lookup and bounds the path-open retry queue for stability.
Written for commit f55ec3f. Summary will update on new commits.