Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eigenda): implement eigenDA client remaining features #3243

Open
wants to merge 131 commits into
base: main
Choose a base branch
from

Conversation

juanbono
Copy link

@juanbono juanbono commented Nov 8, 2024

What ❔

Note:

Related era-contract PR: matter-labs/era-contracts#1233

This PR adds extra functionality to the eigen client:

Why ❔

These features are needed to have a full featured client and to have the same features as when communicating with the EigenDA proxy.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

juan518munoz and others added 23 commits October 31, 2024 17:14
Implement non auth blob dispersal for eigen client

---------

Co-authored-by: Gianbelinche <[email protected]>
feat(eigen-client-extra-features): get inclusion data
* initial commit

* Add tests

* Add memstore

* Add assert to tests

* Add rest of memstore

* Address pr comments

* Remove to retriable error

* Fix conflicts

* Document memstore

* Fix typo

---------

Co-authored-by: Juan Munoz <[email protected]>
blob size limit

---------

Co-authored-by: Gianbelinche <[email protected]>
* initial commit

* Add tests

* Add memstore

* Add assert to tests

* Add rest of memstore

* Add soft confirmations

* Remove print

* Address pr comments

* Remove to retriable error

* Fix conflicts

* Add inclusion data

* Change status query timeout to millis

* Document memstore

* Fix typo

* Fix typo

* Format

---------

Co-authored-by: Juan Munoz <[email protected]>
* initial commit

* Add tests

* Add memstore

* Add assert to tests

* Add rest of memstore

* Address pr comments

* Remove to retriable error

* Fix conflicts

* Add verifier

* Fix verifier

* Add path to points to config

* Fix typo

* Fix eigenda env test

* Fix verifier test

* Move eigendaservicemanager to generated

* Remove unneeded imports

* Document verifier

* Modify errors

* Address comments

* Fix conflicts

---------

Co-authored-by: Juan Munoz <[email protected]>
* initial commit

* move file location

* fix step
#329)

* Remove unused custom quorum numbers

* Add serial to tests
feat(eigen-client-extra-features): fix clippy and add doc
feat(eigen-client-extra-features): merge main
@juanbono juanbono changed the title Eigen client extra features Implement eigenDA client remaining features Nov 8, 2024
juan518munoz and others added 2 commits November 12, 2024 11:02
…dule-update

feat(eigen-client-extra-features): update contracts submodule
Copy link
Contributor

@dimazhornyk dimazhornyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left a couple of nits

core/lib/config/src/configs/da_client/eigen.rs Outdated Show resolved Hide resolved
core/lib/dal/src/data_availability_dal.rs Outdated Show resolved Hide resolved
core/node/da_clients/src/eigen/sdk.rs Outdated Show resolved Hide resolved
core/lib/protobuf_config/src/proto/config/da_client.proto Outdated Show resolved Hide resolved
etc/env/file_based/genesis.yaml Outdated Show resolved Hide resolved
juan518munoz and others added 4 commits February 7, 2025 18:12
* remove `EigenConfig::default()`

* remove irrelevant query conditions

* move comment location

* rename `RawEigenClient` field name

* add won't implement comment

* add `PointsSource` to `EigenConfig`

* address comments

* change test config function name
…merge-main

feat(eigen-client-extra-features): merge main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants