-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eigenda): implement eigenDA client remaining features #3243
Open
juanbono
wants to merge
131
commits into
matter-labs:main
Choose a base branch
from
lambdaclass:eigen-client-extra-features
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(eigenda): implement eigenDA client remaining features #3243
juanbono
wants to merge
131
commits into
matter-labs:main
from
lambdaclass:eigen-client-extra-features
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impl rlp encoding
Implement non auth blob dispersal for eigen client --------- Co-authored-by: Gianbelinche <[email protected]>
feat(eigen-client-extra-features): get inclusion data
add test for remote disperser cfg
* initial commit * Add tests * Add memstore * Add assert to tests * Add rest of memstore * Address pr comments * Remove to retriable error * Fix conflicts * Document memstore * Fix typo --------- Co-authored-by: Juan Munoz <[email protected]>
blob size limit --------- Co-authored-by: Gianbelinche <[email protected]>
* initial commit * Add tests * Add memstore * Add assert to tests * Add rest of memstore * Add soft confirmations * Remove print * Address pr comments * Remove to retriable error * Fix conflicts * Add inclusion data * Change status query timeout to millis * Document memstore * Fix typo * Fix typo * Format --------- Co-authored-by: Juan Munoz <[email protected]>
* initial commit * Add tests * Add memstore * Add assert to tests * Add rest of memstore * Address pr comments * Remove to retriable error * Fix conflicts * Add verifier * Fix verifier * Add path to points to config * Fix typo * Fix eigenda env test * Fix verifier test * Move eigendaservicemanager to generated * Remove unneeded imports * Document verifier * Modify errors * Address comments * Fix conflicts --------- Co-authored-by: Juan Munoz <[email protected]>
* initial commit * move file location * fix step
* Add eth confirmation depth * Fix error
#329) * Remove unused custom quorum numbers * Add serial to tests
feat(eigen-client-extra-features): fix clippy and add doc
feat(eigen-client-extra-features): merge main
12 tasks
…dule-update feat(eigen-client-extra-features): update contracts submodule
…o eigen-client-extra-features-merge-main
…merge-main feat(eigen-client-extra-features): Merge main
3 tasks
…merge Eigen client extra features merge main
3 tasks
…update-contracts feat(eigen-client-extra-features): Merge main and update contracts
dimazhornyk
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, left a couple of nits
dimazhornyk
reviewed
Feb 6, 2025
zkstack_cli/crates/zkstack/src/commands/chain/args/init/da_configs.rs
Outdated
Show resolved
Hide resolved
* remove `EigenConfig::default()` * remove irrelevant query conditions * move comment location * rename `RawEigenClient` field name * add won't implement comment * add `PointsSource` to `EigenConfig` * address comments * change test config function name
…merge-main feat(eigen-client-extra-features): merge main
dimazhornyk
reviewed
Feb 11, 2025
…fix-hashes fix(eigen-client-extra-features): fix hashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Note:
Related era-contract PR: matter-labs/era-contracts#1233
This PR adds extra functionality to the eigen client:
Why ❔
These features are needed to have a full featured client and to have the same features as when communicating with the EigenDA proxy.
Checklist
zkstack dev fmt
andzkstack dev lint
.