Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eigenda): implement eigenDA client remaining features #3243
base: main
Are you sure you want to change the base?
feat(eigenda): implement eigenDA client remaining features #3243
Changes from 59 commits
fcecc81
2bcf78f
537cf92
f58e0bf
04b93e6
c121eca
4a38ee2
e64cc2e
5b8665b
aa9f1b2
e033630
b164870
f95bc1b
9c06b40
3b9e766
6668ab9
cc9e2be
9769a17
91bb79b
cbe124e
9c73b3f
94ecb52
342b476
077bc13
c98726a
991c340
f55a424
f2fb12c
b825d4f
9561bc3
986a1d2
09ecfdd
a2ddcc3
7d369a8
a9c31a7
6e1de82
8d0b908
28c826c
68abc97
99b153a
01b50ed
daace34
99c6d42
163c41a
cef9a89
75090b6
7a61574
bc90cc6
87d450f
e2d4dab
4d1fadb
4bb08b9
0d01df7
2100256
83c3e13
fe8f68c
64a08bc
8395cca
f2d7941
4b3c059
93b94b2
068f90f
9e1ebfa
c007aa8
2e7d6cc
405b413
9b6fe48
5a144ad
2431a0c
a880375
801aca6
cd4c631
68825c4
e3b6f17
2bded08
12d29c7
351d5a8
d312b51
57f608e
1832819
3a97228
5c4309d
a66e9eb
c89d8c2
2880367
5a7e533
87d5e0d
ab6a374
c3cb48c
de8ad1a
c476920
d64acd2
709adca
0b1397e
e2ae59c
d3f1faf
bfcd206
278975c
56cda84
cfba485
b0b080d
efdf1b4
2587277
28de691
1870c2a
b68a43e
0575785
51e88d3
b33700b
2080f16
1273ed2
889b513
efa3a4b
9075650
f60bbf5
da3fd9e
2116030
d6eb001
e17b879
ca4f11a
34df5ff
34e21b5
bdcb268
f0093c5
9810b37
3c2e049
b7306cc
c1936c3
92b1ca6
ed37e47
e5108bf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this URL works as an ordinary Web3 provider URL, please use
SensitiveUrl
here, since it may contain sensitive parts for authentication.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, it was fixed here lambdaclass#386
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not
Address
? Also, again, addresses don't have meaningful defaults, and""
is not a valid address.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed here lambdaclass#375, the testnet URL was used as default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about making this an
Address
? AFAIU, it is parsed as such down the line.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed here lambdaclass#383, the type is now
Address
as suggested.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any integrity checks for the file contents? What is the outcome of receiving invalid points (e.g., is this an attack vector)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The outcome will be that with invalid points the verification will fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chain_id
is removed from the verifier config (see the other comment), this looks unused.GatewayChainId
? If this config param is redundant, it shouldn't be copied; instead, the existing param should be reused.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed here lambdaclass#386
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.