Fix hubspot form build #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mdubus
reviewed
Mar 3, 2025
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "mini-dashboard", | |||
| "version": "0.2.17", | |||
| "version": "0.2.18", | |||
There was a problem hiding this comment.
Can we create a different PR for the version upgrade? 🙏
There was a problem hiding this comment.
We want to be fast on this one since the engine team is waiting + timezone issue between Laurent and us, so I would go with this even if it's not really clean, I agree 😊
There was a problem hiding this comment.
Thanks for the feedback, I will keep that in mind for the future.
| @@ -18,4 +20,13 @@ describe(`Right side panel`, () => { | |||
| cy.get('button[aria-label="Open Panel"]').click() | |||
| cy.get('[data-testid="right-panel"]').should('be.visible') | |||
| }) | |||
|
|
|||
| it('Should allow subscribing to the newsletter', () => { | |||
| cy.get('input[placeholder="Enter your email"]').type('[email protected]') | |||
There was a problem hiding this comment.
Will this trigger the subscription, or is it caught somewhere to not send it in testing environment?
There was a problem hiding this comment.
This triggers a subscription, but nothing happens when you subscribe with an existing email.
There was a problem hiding this comment.
Can you explain what you mean by "nothing happens when you subscribe with an existing email"?
There was a problem hiding this comment.
You can see that there are multiple submissions, but the contact is simply "upserted" there is no duplicate contacts created in HubSpot. You can see the forms submissions here: https://app-eu1.hubspot.com/submissions/25945010/form/991e2a09-77c2-4428-9242-ebf26bfc6c64/submissions?redirectUrl=https://app-eu1.hubspot.com/forms/25945010/views/all_forms
There was a problem hiding this comment.
Ok I'm wondering if we could have improved it by either providing a fake email or having intercepted the request to avoid spamming Hubspot's API 🤔
Approving for now since it's urgent but we should consider doing this test in a different way 🥲
mdubus
approved these changes
Mar 4, 2025
|
bors merge |
|
Build succeeded:
|
5 tasks
meili-bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Mar 4, 2025
5385: Bump mini-dashboard v0.2.18 r=Kerollmops a=Strift ## Description The previous build didn't have the environment variable correctly configured, so form submissions didn't work. We fixed the build in meilisearch/mini-dashboard#592, and this PR uses the new mini-dashboard build. Related to #5361. ## To-do - [x] Update assets-url - [x] Update sha1 ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! 5388: Update version for the next release (v1.13.3) in Cargo.toml r=Kerollmops a=meili-bot⚠️ This PR is automatically generated. Check the new version is the expected one and Cargo.lock has been updated before merging. Co-authored-by: Strift <[email protected]> Co-authored-by: Kerollmops <[email protected]> Co-authored-by: Kerollmops <[email protected]>
meili-bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Mar 4, 2025
5385: Bump mini-dashboard v0.2.18 r=Kerollmops a=Strift ## Description The previous build didn't have the environment variable correctly configured, so form submissions didn't work. We fixed the build in meilisearch/mini-dashboard#592, and this PR uses the new mini-dashboard build. Related to #5361. ## To-do - [x] Update assets-url - [x] Update sha1 ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! 5388: Update version for the next release (v1.13.3) in Cargo.toml r=Kerollmops a=meili-bot⚠️ This PR is automatically generated. Check the new version is the expected one and Cargo.lock has been updated before merging. Co-authored-by: Strift <[email protected]> Co-authored-by: Kerollmops <[email protected]> Co-authored-by: Kerollmops <[email protected]>
meili-bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Mar 4, 2025
5385: Bump mini-dashboard v0.2.18 r=Kerollmops a=Strift ## Description The previous build didn't have the environment variable correctly configured, so form submissions didn't work. We fixed the build in meilisearch/mini-dashboard#592, and this PR uses the new mini-dashboard build. Related to #5361. ## To-do - [x] Update assets-url - [x] Update sha1 ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Strift <[email protected]>
meili-bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Mar 4, 2025
5385: Bump mini-dashboard v0.2.18 r=Kerollmops a=Strift ## Description The previous build didn't have the environment variable correctly configured, so form submissions didn't work. We fixed the build in meilisearch/mini-dashboard#592, and this PR uses the new mini-dashboard build. Related to #5361. ## To-do - [x] Update assets-url - [x] Update sha1 ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! 5391: Skip snapshots on windows r=dureuill a=Kerollmops Reapplying #5383 in v1.13.3 because it blocks the CI. Co-authored-by: Strift <[email protected]> Co-authored-by: Kerollmops <[email protected]>
meili-bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Mar 4, 2025
5385: Bump mini-dashboard v0.2.18 r=Kerollmops a=Strift ## Description The previous build didn't have the environment variable correctly configured, so form submissions didn't work. We fixed the build in meilisearch/mini-dashboard#592, and this PR uses the new mini-dashboard build. Related to #5361. ## To-do - [x] Update assets-url - [x] Update sha1 ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Strift <[email protected]>
meili-bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Mar 5, 2025
5385: Bump mini-dashboard v0.2.18 r=Kerollmops a=Strift ## Description The previous build didn't have the environment variable correctly configured, so form submissions didn't work. We fixed the build in meilisearch/mini-dashboard#592, and this PR uses the new mini-dashboard build. Related to #5361. ## To-do - [x] Update assets-url - [x] Update sha1 ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Strift <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
prebuildscript that checks that the env are available