fix(nav): maintain consistent width on mobile and tablet, enable vert…#2603
fix(nav): maintain consistent width on mobile and tablet, enable vert…#2603Katotodan wants to merge 5 commits intomeshery:masterfrom
Conversation
…ical scroll Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @Katotodan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves responsiveness issues within the application's navigation system on mobile and tablet devices. The primary goal was to ensure a stable and predictable user interface, particularly when interacting with navigation menus and dropdowns, by controlling their dimensions and behavior on smaller viewports. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
…ical scroll Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request addresses responsiveness issues on mobile and tablet devices by ensuring a consistent navigation width and enabling vertical scrolling for overflowing content. The changes primarily involve adjustments to CSS in _sass/navigation.scss and minor HTML formatting in _includes/header.html and _includes/navigation.html. The changes improve the user experience on smaller screens by preventing unexpected layout shifts.
_sass/navigation.scss
Outdated
| width: 95vw !important; | ||
| max-width: calc(100vw - 1rem) !important; |
There was a problem hiding this comment.
@saurabhraghuvanshii I have remove the !important on my last commit. Please review when you can. Thanks!
…ical scroll Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
…ical scroll Signed-off-by: DANIEL KATOTO <katotodan@gmail.com>
|
@Katotodan Thank you for your contribution! Let's discuss this during the website call today at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
Description
This PR fixes the navigation responsiveness issue on mobile and tablet devices.
Previously, when the menu icon was clicked, the navigation list appeared with a small width. When a dropdown item inside the navigation was expanded, the width of the navigation container increased unexpectedly, causing layout instability on smaller viewports.
Changes Made
Before:
Screen.Recording.2026-02-24.at.10.49.04.mov
After
Screen.Recording.2026-02-24.at.10.51.32.mov
This PR fixes #2602
Notes for Reviewers
Signed commits