Skip to content

fix(nav): maintain consistent width on mobile and tablet, enable vert… #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Katotodan wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(nav): maintain consistent width on mobile and tablet, enable vert… #2603

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
275549c
fix(nav): maintain consistent width on mobile and tablet, enable vert…
Katotodan Feb 24, 2026
f45a6ce
fix(nav): maintain consistent width on mobile and tablet, enable vert…
Katotodan Feb 24, 2026
8de1549
fix(nav): maintain consistent width on mobile and tablet, enable vert…
Katotodan Feb 26, 2026
3ebb33a
fix(nav): maintain consistent width on mobile and tablet, enable vert…
Katotodan Feb 28, 2026
9f286f4
Merge branch 'master' into fix/navbar-responsiveness
CodexRaunak Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions _includes/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@
'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
})(window,document,'script','dataLayer','GTM-KL6SSW5');</script>
<!-- End Google Tag Manager -->
{% seo %} {% feed_meta %} {% if jekyll.environment == 'production' %}
{% seo %} {% feed_meta %}
<link rel="stylesheet" href="{{ site.baseurl }}/css/stellarnav.css" />
<!-- {% if jekyll.environment == 'production' %}

{% else %}
<link rel="stylesheet" href="{{ site.baseurl }}/css/stellarnav.css" />
{% endif %}
{% endif %} -->
<link rel="stylesheet" href="{{ site.baseurl }}/css/screen.css" />
<link rel="icon" type="image/png" href="{{ site.baseurl }}/favicon.ico" />
<link
Expand Down
2 changes: 1 addition & 1 deletion _includes/navigation.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
</a>

{% if link.subitems[0] %}
<ul class="">
<ul class="">
{% for sublink in link.subitems %}
<li >
<div {% if sublink.link == page.url %} class="sub-nav-li sub-nav-li--active" {% else %} class="sub-nav-li" {% endif %}>
Expand Down
20 changes: 16 additions & 4 deletions _sass/navigation.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,12 +227,24 @@ a.nav-text:hover {

.stellarnav.mobile {

& .nav-list{
position: absolute;
left:0;
translate: 0 -5px;
& ul.nav-list{
position: fixed;
left: 50%;
transform: translateX(-50%);
top: 4rem;
background: transparent;
background-color: var(--color-primary-light);
width: 95vw !important;
max-width: calc(100vw - 1rem) !important;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using !important should generally be avoided as it can make CSS harder to maintain and debug by overriding normal cascade rules. Consider if there's a way to achieve the desired specificity without !important.

Copy link
Member

@saurabhraghuvanshii saurabhraghuvanshii Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katotodan Also address this.

Copy link
Author

@Katotodan Katotodan Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhraghuvanshii I have remove the !important on my last commit. Please review when you can. Thanks!

max-height: 70vh;
overflow-y: auto;
overflow-x: hidden;
padding: 0 0.5rem 0.5rem 0.5rem;
box-shadow: 0 6px 10px -2px rgba(0,211,169,0.75);
-webkit-box-shadow: 0 6px 10px -2px rgba(0,211,169,0.75);
-moz-box-shadow: 0 6px 10px -2px rgba(0,211,169,0.75);
z-index: 100;

}

& li a {
Expand Down
Loading