Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2244 ic date input improve deletion of full date via keyboard #3239

Conversation

GCHQ-Developer-530
Copy link
Contributor

Summary of the changes

Add the ability to backspace through a date input to delete the date, using moveToPreviousInput after the last character has been deleted

Related issue

#2244

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • Min/max content examples tested with no loss of content or overflow.
  • All prop combinations work without issue.
  • Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • Controlled and uncontrolled input components tested.
  • Props/slots can be updated after initial render.

@GCHQ-Developer-530 GCHQ-Developer-530 force-pushed the 2244-ic-date-input-improve-deletion-of-full-date-via-keyboard branch from d362b32 to 956cf1a Compare February 21, 2025 14:07
@ad9242
Copy link
Contributor

ad9242 commented Feb 24, 2025

works great when a full date is set & you want to delete, but I can't seem to use the backspace key if, say, I type a value in for dd & want to go back and change it. The focus just stays in the mm part (same for yyyy too, if you are trying to go back to mm)

image

…ate input to delete the date

Add the ability to backspace through a date input to delete the date, using moveToPreviousInput
after the last character has been deleted

. #2244
… to delete the date

Add the ability to backspace through a date input to delete the date, using moveToPreviousInput
after the last character has been deleted

. #2244
@GCHQ-Developer-530 GCHQ-Developer-530 force-pushed the 2244-ic-date-input-improve-deletion-of-full-date-via-keyboard branch from 956cf1a to 534252c Compare February 24, 2025 08:42
@GCHQ-Developer-530 GCHQ-Developer-530 merged commit aea384c into develop Feb 24, 2025
6 checks passed
@GCHQ-Developer-530 GCHQ-Developer-530 deleted the 2244-ic-date-input-improve-deletion-of-full-date-via-keyboard branch February 24, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants