Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference of Metagenome in MetaT related yamls #388

Open
kaijli opened this issue Feb 20, 2025 · 0 comments
Open

Reference of Metagenome in MetaT related yamls #388

kaijli opened this issue Feb 20, 2025 · 0 comments

Comments

@kaijli
Copy link
Contributor

kaijli commented Feb 20, 2025

- Metagenome Raw Read 1
- Metagenome Raw Read 2
- Name: Sequencing Interleaved
Collection: data_generation_set
Enabled: True
Analyte Category: Metatranscriptome
Filter Output Objects:
- Metagenome Raw Reads

Type: nmdc:ReadQcAnalysis
Git_repo: https://github.com/microbiomedata/metaT_ReadsQC
Version: v0.0.7
Collection: workflow_execution_set
WorkflowExecutionRange: ReadQcAnalysis
Inputs:
- Metagenome Raw Reads
Workflow_Execution:
name: "Read QC for {id}"
input_read_bases: "{outputs.stats.input_read_bases}"
input_read_count: "{outputs.stats.input_read_count}"
output_read_bases: "{outputs.stats.output_read_bases}"
output_read_count: "{outputs.stats.output_read_count}"
type: nmdc:ReadQcAnalysis
Outputs:
- Filtered Sequencing Reads
- QC Statistics
- rRNA Filtered Sequencing Reads
- Read Filtering Info File

🔴 I believe these should say Metatranscriptome instead of Metagenome. Unless my understanding of the workflows and data types is totally wrong.

🟡 Also raising a flag that ReadsQC workflow task is called the same nmdc:ReadQcAnalysis for both metaG and metaT but none of the other workflow execution IDs are the same (whereas if we are naming based off whether they're the same WDL workflow or not, only nmdc:MetagenomeAnnotation would be the same)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant