improvement(routerlicious-driver): change Object.keys to Object.entries #23710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
base: main
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- packages/drivers/routerlicious-driver/src/summaryTreeUploadManager.ts: Evaluated as low risk
jason-ha
requested changes
Jan 31, 2025
RishhiB
changed the title
jason-ha
approved these changes
Feb 6, 2025
tylerbutler
pushed a commit
to tylerbutler/FluidFramework
that referenced
this pull request
Feb 6, 2025
…es (microsoft#23710) Prepare for enabling no-unchecked-record-access / noUncheckedIndexedAccess in routerlicious-driver by switching Object.keys to Object.entries. Full type safety will require additional changes in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for enabling no-unchecked-record-access / noUncheckedIndexedAccess in routerlicious-driver by switching Object.keys to Object.entries. Full type safety will require additional changes in a future PR.