fix(uimode): show trace failure and any error messages on missing trace#35344
Merged
agg23 merged 6 commits intomicrosoft:mainfrom Apr 3, 2025
Merged
fix(uimode): show trace failure and any error messages on missing trace#35344agg23 merged 6 commits intomicrosoft:mainfrom
agg23 merged 6 commits intomicrosoft:mainfrom
Conversation
agg23
commented
Mar 25, 2025
|
|
||
| await page.getByTestId('test-tree').getByText('basic fail').dblclick(); | ||
| await expect(page.getByRole('tabpanel', { name: 'Actions' })).toContainText('Failed'); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
If someone knows how to test the failure case, I'd love to know. It either requires blocking the fetch request or blocking the trace from being written/read.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"7 flaky38844 passed, 809 skipped Merge workflow run. |
Member
|
This is a normal behavior for the live mode, we start with empty / malformed zip and over time populate it. I would not want error to flicker for the user. |
This comment has been minimized.
This comment has been minimized.
| setModel(undefined); | ||
| setTrace({ type: 'success', model, isLive: true }); | ||
| } catch (e) { | ||
| const errors = result.errors.flatMap(error => !!error.message ? [error.message] : []); |
Member
There was a problem hiding this comment.
So I wonder why something like this instead of this change does not work:
const errors = result.errors.flatMap(error => !!error.message ? [error.message] : []);
const modelWithErrors = new MultiTraceModel([]);
modelWithErrors.errorDescriptors.push(...errors.map(message => ({ message })));
setModel({ model: modelWithErrors, isLive: false });
Contributor
Author
There was a problem hiding this comment.
I have updated the PR to have that form. By doing so, you lose:
- Expressiveness in having a discriminated union enumerate possible states (no data vs we have data (live or not) vs we have failed to get data).
modelstability in the error case; it will create a new error model every 500ms and React will do a full rerender of the child tree.- A more complete failure error message next to the actions (which you probably didn't like anyway).
Contributor
Test results for "tests 1"1 failed 4 flaky39019 passed, 805 skipped Merge workflow run. |
pavelfeldman
approved these changes
Apr 3, 2025
whazor
pushed a commit
to whazor/playwright-trace-viewer-plus
that referenced
this pull request
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If UI Mode ever could not fetch a trace, whether it was not generated or something else went wrong, it would not indicate to the user what happened. With this change, a specific error message is added to the UI if we cannot find a trace after the test has stopped running. Any error messages we can extract from the test tree are also displayed.
Discovered by #35152.