Skip to content

fix(uimode): show trace failure and any error messages on missing trace #35344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agg23 merged 6 commits into from
Apr 3, 2025
Merged

fix(uimode): show trace failure and any error messages on missing trace #35344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
626ca9f
fix(uimode): show trace failure and any error messages on missing trace
agg23 Mar 25, 2025
f3e1c8f
Fix incorrect prop
agg23 Mar 25, 2025
69b0c7a
Group trace load failure with fallbackSource location
agg23 Mar 31, 2025
62418c7
Collapsed fix into minimal version
agg23 Apr 1, 2025
8dfd220
Remove unused type
agg23 Apr 1, 2025
228eab8
Remove incorrect error type
agg23 Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/trace-viewer/src/ui/uiModeTraceView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const TraceView: React.FC<{
revealSource?: boolean,
pathSeparator: string,
}> = ({ item, rootDir, onOpenExternally, revealSource, pathSeparator }) => {
const [model, setModel] = React.useState<{ model: MultiTraceModel, isLive: boolean } | undefined>();
const [model, setModel] = React.useState<{ model: MultiTraceModel, isLive: boolean } | undefined>(undefined);
const [counter, setCounter] = React.useState(0);
const pollTimer = React.useRef<NodeJS.Timeout | null>(null);

Expand Down Expand Up @@ -75,7 +75,9 @@ export const TraceView: React.FC<{
const model = await loadSingleTraceFile(traceLocation);
setModel({ model, isLive: true });
} catch {
setModel(undefined);
const model = new MultiTraceModel([]);
model.errorDescriptors.push(...result.errors.flatMap(error => !!error.message ? [{ message: error.message }] : []));
setModel({ model, isLive: false });
} finally {
setCounter(counter + 1);
}
Expand Down
24 changes: 24 additions & 0 deletions tests/playwright-test/ui-mode-trace.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,3 +526,27 @@ test('fails', async ({ page }) => {
5 | });
`.trim());
});

test('should indicate current test status', async ({ runUITest }) => {
const { page } = await runUITest({
'a.spec.ts': `
import { test, expect } from '@playwright/test';
test('basic pass', async ({ page }) => {
await page.setContent('<button>Submit</button>');
await new Promise(resolve => setTimeout(resolve, 1000));
expect(1).toBe(1);
});
test('basic fail', async ({ page }) => {
await page.setContent('<button>Submit</button>');
expect(1).toBe(2);
});
`.trim(),
});

await page.getByTestId('test-tree').getByText('basic pass').dblclick();
await expect(page.getByRole('tabpanel', { name: 'Actions' })).toContainText('Running');
await expect(page.getByRole('tabpanel', { name: 'Actions' })).toContainText('Passed');

await page.getByTestId('test-tree').getByText('basic fail').dblclick();
await expect(page.getByRole('tabpanel', { name: 'Actions' })).toContainText('Failed');
});
Copy link
Contributor Author

@agg23 agg23 Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone knows how to test the failure case, I'd love to know. It either requires blocking the fetch request or blocking the trace from being written/read.

Loading