Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[liblzma] Add license #43806

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jimwang118
Copy link
Contributor

Fixes #43797

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@jimwang118 jimwang118 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Feb 13, 2025
"description": "Compression library with an API similar to that of zlib.",
"homepage": "https://tukaani.org/xz/",
"license": null,
"license": "0BSD OR GPL-2.0-or-later OR GPL-3.0-only",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you take this information from?
AFAICT the license is 0BSD for the lib, and more complicated for tools.
Cf. https://sources.debian.org/src/xz-utils/5.6.3-1/debian/copyright/
So OR indicates a choice which doesn't apply to all binaries.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(And that's why there is null now.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the upstream copyright, it is true that lib uses OBSD, and other tools use two other licenses. So should we still use null and not pay attention to the used license?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of null is "to indicate that users must read the deployed /share/<port>/copyright file."
https://learn.microsoft.com/en-us/vcpkg/reference/vcpkg-json#license

You might perhaps use might use 0BSD for the core, and another license field for the tools feature. But there isn't much room for OR in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[liblzma] Setting the license
3 participants