Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[liblzma] Add license #43806

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[liblzma] Add license #43806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56bc625
add license
jimwang118 Feb 13, 2025
bcf6872
update version
jimwang118 Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ports/liblzma/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
{
"name": "liblzma",
"version": "5.6.3",
"port-version": 1,
"description": "Compression library with an API similar to that of zlib.",
"homepage": "https://tukaani.org/xz/",
"license": null,
"license": "0BSD OR GPL-2.0-or-later OR GPL-3.0-only",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you take this information from?
AFAICT the license is 0BSD for the lib, and more complicated for tools.
Cf. https://sources.debian.org/src/xz-utils/5.6.3-1/debian/copyright/
So OR indicates a choice which doesn't apply to all binaries.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(And that's why there is null now.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the upstream copyright, it is true that lib uses OBSD, and other tools use two other licenses. So should we still use null and not pay attention to the used license?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of null is "to indicate that users must read the deployed /share/<port>/copyright file."
https://learn.microsoft.com/en-us/vcpkg/reference/vcpkg-json#license

You might perhaps use might use 0BSD for the core, and another license field for the tools feature. But there isn't much room for OR in my opinion.

"dependencies": [
{
"name": "vcpkg-cmake",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4786,7 +4786,7 @@
},
"liblzma": {
"baseline": "5.6.3",
"port-version": 0
"port-version": 1
},
"libmad": {
"baseline": "0.16.4",
Expand Down
5 changes: 5 additions & 0 deletions versions/l-/liblzma.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "1751ecdcd51a32ee52682f4a258a23278aaa96f6",
"version": "5.6.3",
"port-version": 1
},
{
"git-tree": "b5e5694620b41a4d668390e5d14fa2326e0afdc3",
"version": "5.6.3",
Expand Down