Skip to content

Conversation

@TSMMark
Copy link

@TSMMark TSMMark commented Dec 8, 2022

Solves this comment #62 (comment)

I tested locally by installing from dev build like:

yarn vscode:prepublish
yarn global add vsce
$(yarn global bin)/vsce package
code --install-extension ruby-rubocop-0.8.6.vsix

And I no longer get the warning:

image

Copy link

@Skipants Skipants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TSMMark This change is awesome, much needed, and can't wait to see it merged. I hope you don't mind my random review -- I noticed this can be simplified slightly.

@TSMMark
Copy link
Author

TSMMark commented Apr 3, 2023

Can this get a review + merge + release from a maintainer? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants