Skip to content

Don't warn "Found multiple files" when they are the same file #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Don't warn "Found multiple files" when they are the same file #174

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38a8afd
try: dont warn Found multiple files when they are the same file
TSMMark Dec 8, 2022
05bd093
s/clic/click/
TSMMark Dec 8, 2022
3a5fa89
path.resolve is no-op when already absolute
TSMMark Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ gem install rubocop

If VSCode market place is not configured in your FLOSS distribution of code (you have Open VSX instead):

1. Go on [VSCode Marketplace](https://marketplace.visualstudio.com/items?itemName=misogi.ruby-rubocop) and clic on the [Download Extension](https://marketplace.visualstudio.com/_apis/public/gallery/publishers/misogi/vsextensions/ruby-rubocop/0.8.5/vspackage) button.
1. Go on [VSCode Marketplace](https://marketplace.visualstudio.com/items?itemName=misogi.ruby-rubocop) and click on the [Download Extension](https://marketplace.visualstudio.com/_apis/public/gallery/publishers/misogi/vsextensions/ruby-rubocop/0.8.5/vspackage) button.
2. Install the extension manually from the CLI: `code --install-extension misogi.ruby-rubocop-0.8.5.vsix`

# ChangeLog
Expand Down
11 changes: 10 additions & 1 deletion src/rubocop.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,22 @@ function getCurrentPath(fileUri: vscode.Uri): string {
function getCommandArguments(fileName: string): string[] {
let commandArguments = ['--stdin', fileName, '--force-exclusion'];
const extensionConfig = getConfig();

if (extensionConfig.configFilePath !== '') {
const found = [extensionConfig.configFilePath]
const expandedConfigFilePath = path.isAbsolute(
extensionConfig.configFilePath
)
? extensionConfig.configFilePath
: path.resolve(extensionConfig.configFilePath);

const found = [expandedConfigFilePath]
.concat(
(vscode.workspace.workspaceFolders || []).map((ws) =>
path.join(ws.uri.path, extensionConfig.configFilePath)
)
)
// dedupe
.filter((v, i, a) => a.indexOf(v) === i)
.filter((p: string) => fs.existsSync(p));

if (found.length == 0) {
Expand Down