Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fully remove puppetdb management from nebula #770

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fully remove puppetdb management from nebula #770

merged 1 commit into from
Dec 13, 2024

Conversation

rrotter
Copy link
Member

@rrotter rrotter commented Dec 10, 2024

Previously puppetdb was commented out, and tests were disabled with xit.

@rrotter rrotter requested a review from daaang December 10, 2024 21:58
daaang
daaang approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@daaang daaang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good, but I would also support deleting the master_with_db profile (it's only mentioned in role::puppet::master) and both spec files.

manifests/profile/puppet/db.pp
# disable_cleartext => true,
# manage_firewall => false,
#}
# puppetdb is no longer managed by nebula
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good comment

@rrotter
fully remove puppetdb management from nebula
ab27142 
Previously puppetdb was commented out, and tests were disabled with xit.
@rrotter rrotter merged commit 8921e1d into production Dec 13, 2024
1 check passed
@rrotter rrotter deleted the rm_puppetdb branch December 13, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daaang daaang daaang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rrotter @daaang