Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fully remove puppetdb management from nebula #770

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fully remove puppetdb management from nebula #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions manifests/profile/puppet/db.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,5 @@
# @example
# include nebula::profile::puppet::db
class nebula::profile::puppet::db {
#class { 'puppetdb':
# disable_cleartext => true,
# manage_firewall => false,
#}
# puppetdb is no longer managed by nebula
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good comment

}
17 changes: 0 additions & 17 deletions manifests/profile/puppet/master_with_db.pp
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion manifests/role/puppet/master.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
class nebula::role::puppet::master {
include nebula::role::umich
include nebula::profile::puppet::master
include nebula::profile::puppet::master_with_db
include nebula::profile::certbot_route53
include nebula::profile::certbot_cloudflare

Expand Down
7 changes: 2 additions & 5 deletions spec/classes/profile/puppet/db_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,8 @@
context "on #{os}" do
let(:facts) { os_facts }

xit do
expect(subject).to contain_class('puppetdb').with(
disable_cleartext: true,
manage_firewall: false,
)
it do
expect(subject).not_to contain_class('puppetdb')
end
end
end
Expand Down
31 changes: 0 additions & 31 deletions spec/classes/profile/puppet/master_with_db_spec.rb
View file
Open in desktop

This file was deleted.

Loading