Skip to content

fix(Combobox): Remove default bottom margin to align with Figma spacing #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(Combobox): Remove default bottom margin to align with Figma spacing #2902

wants to merge 2 commits into from

Conversation

@orrgottlieb
Copy link
Contributor

Resolves #

@orrgottlieb orrgottlieb requested a review from a team as a code owner May 22, 2025 07:20
YossiSaadi
YossiSaadi reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should make this an opt-in behavior, as consumers might get a messed layout as a result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YossiSaadi YossiSaadi YossiSaadi left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@orrgottlieb @YossiSaadi