Skip to content

fix(Combobox): Remove default bottom margin to align with Figma spacing #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(Combobox): Remove default bottom margin to align with Figma spacing #2902

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1417169
fix(Combobox): Remove default bottom margin to align with Figma spacing
orrgottlieb May 22, 2025
1e94548
merge: from master
orrgottlieb May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/core/src/components/Combobox/Combobox.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
display: flex;
flex-direction: column;
position: relative;
margin-bottom: var(--spacing-small);
margin-bottom: 0;
}

.combobox.stickyCategory .comboboxCategory {
Expand Down Expand Up @@ -46,7 +46,7 @@
height: calc(100% - 20px);
overflow: hidden;
position: relative;
padding: 0 16px;
padding: 0 var(--spacing-medium);
display: flex;
flex-direction: column;
}
Expand All @@ -65,7 +65,7 @@
.comboboxNoResults .addNewButton {
flex: 0 0 auto;
width: 100% !important;
margin-bottom: 8px;
margin-bottom: var(--spacing-small);
}

.comboboxNoResults .addNewButton .buttonLabel {
Expand All @@ -76,6 +76,6 @@
display: flex;
flex-direction: column;
flex: 1 1 auto;
padding: 0 4px;
padding: 0 var(--spacing-xs);
overflow: hidden;
}