Map ompl's APPROXIMATE_SOLUTION -> TIMED_OUT / PLANNING_FAILED (backport #2455) #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
ompl's APPROXIMATE_SOLUTION is not suitable for actual execution. It just states that we got closer to the goal... The most prominent reason for an approximate solution is a timeout. Thus, return TIMED_OUT and print the used timeouts for convenience. (cherry picked from commit c0c6baf)
sjahr
approved these changes
Oct 18, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## iron #2460 +/- ##
==========================================
+ Coverage 50.72% 50.73% +0.02%
==========================================
Files 386 386
Lines 31958 31960 +2
==========================================
+ Hits 16206 16212 +6
+ Misses 15752 15748 -4
☔ View full report in Codecov by Sentry. |
henningkayser
approved these changes
Oct 24, 2023
medvedevigorek
pushed a commit
to AivotRobotics/moveit2
that referenced
this pull request
Nov 2, 2023
…ort moveit#2455) (moveit#2460) ompl's APPROXIMATE_SOLUTION is not suitable for actual execution. It just states that we got closer to the goal... The most prominent reason for an approximate solution is a timeout. Thus, return TIMED_OUT and print the used timeouts for convenience. (cherry picked from commit c0c6baf) Co-authored-by: Robert Haschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2455 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com