Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyediting of translatable strings in response to ja translation #232

Merged
merged 12 commits into from
Nov 19, 2024

Conversation

cooljeanius
Copy link
Collaborator

@cooljeanius cooljeanius commented Nov 17, 2024

In PR #230, @k-konami added a bunch of comments pointing out certain things in the source strings that might need changes. In this PR, I am addressing these comments. See issue #10 for more info.

@cooljeanius cooljeanius marked this pull request as ready for review November 18, 2024 00:03
@cooljeanius
Copy link
Collaborator Author

Hey @Konrad22, @k-konami was wondering about one of your previous suggestions in here

it was unused and confusing at least 1 translator; see issue #57
@cooljeanius
Copy link
Collaborator Author

The issue with the end text is wesnoth/wesnoth#6041, by the way

@cooljeanius
Copy link
Collaborator Author

ok phew I was worried there might be a merge conflict after merging PR #233 from @alxrem, but luckily none have arisen...

Copy link
Collaborator Author

@cooljeanius cooljeanius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, merging now

@cooljeanius cooljeanius merged commit 7907c53 into nemaara:master Nov 19, 2024
2 checks passed
@cooljeanius cooljeanius deleted the post_ja_merge_copyediting branch November 19, 2024 18:52
@cooljeanius
Copy link
Collaborator Author

The issue with the end text is wesnoth/wesnoth#6041, by the way

...and this is now closed with wesnoth/wesnoth@33f8dfd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant