-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copyediting of translatable strings in response to ja translation #232
Merged
cooljeanius
merged 12 commits into
nemaara:master
from
cooljeanius:post_ja_merge_copyediting
Nov 19, 2024
Merged
Copyediting of translatable strings in response to ja translation #232
cooljeanius
merged 12 commits into
nemaara:master
from
cooljeanius:post_ja_merge_copyediting
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and a few other changes while I'm at it)
it was unused and confusing at least 1 translator; see issue #57
The issue with the end text is wesnoth/wesnoth#6041, by the way |
cooljeanius
commented
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, merging now
...and this is now closed with wesnoth/wesnoth@33f8dfd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #230, @k-konami added a bunch of comments pointing out certain things in the source strings that might need changes. In this PR, I am addressing these comments. See issue #10 for more info.