Add optional support for per-thread timers and timing MPI synchronization #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… thread synchronization time
JanVogelsang
added
S: Normal
heplesser
changed the title
heplesser
reviewed
Dec 9, 2024
JanVogelsang
commented
Dec 9, 2024
heplesser
requested changes
Dec 9, 2024
There was a problem hiding this comment.
@JanVogelsang Thanks for the PR! Please look at my comments starting at the very end—I am wondering another approach that would avoid macros.
mlober
suggested changes
Dec 12, 2024
mlober
suggested changes
Dec 12, 2024
mlober
reviewed
Dec 13, 2024
…r into nest-master
heplesser
requested changes
Feb 6, 2025
There was a problem hiding this comment.
@JanVogelsang Thanks a lot, this is a very nice implementation! I have some comments, mostly related to naming, const-ness and documentation.
Co-authored-by: Hans Ekkehard Plesser <[email protected]>
|
@JanVogelsang This looks very good now. I just sent you a PR that solves the Clang compilation problem (gcc is too lenient ...). |
Fix build failure with clang/macos
|
@heplesser Thanks for the PR! Should we also get rid of the timers namespace? |
We can keep it for now, maybe remove it in a later PR. |
heplesser
approved these changes
Feb 6, 2025
heplesser
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to measure timers per thread and added timers to measure thread synchronization time. With this PR, we are hoping to be able to identify idle time of individual threads and identify black time present with the current timers.