Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for simple and advance search #11863

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Add documentation for simple and advance search #11863

merged 1 commit into from
Jul 25, 2024

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented May 27, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

Screenshot from 2024-07-25 10-23-41

@GretaD GretaD self-assigned this May 27, 2024
@GretaD

This comment was marked as outdated.

Sign in to view
@GretaD GretaD requested review from kesselb and hamza221 June 20, 2024 09:08
@GretaD GretaD marked this pull request as ready for review June 20, 2024 09:09
@GretaD GretaD requested a review from ChristophWurst as a code owner June 20, 2024 09:10
@kesselb
Copy link
Contributor

kesselb commented Jun 20, 2024

Please move

  • user_manual/images/search-modal.png to user_manual/groupware/images/search-modal.png
  • user_manual/images/search-modal.png to user_manual/groupware/images/search-modal.png

kesselb
kesselb reviewed Jun 20, 2024
View reviewed changes
user_manual/groupware/mail.rst Outdated Show resolved Hide resolved
user_manual/groupware/mail.rst Outdated Show resolved Hide resolved
ChristophWurst
ChristophWurst requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the screenshot because it will get outdated quicky and they contain sensitive information

@GretaD GretaD requested review from kesselb and ChristophWurst June 21, 2024 07:17
@GretaD
Copy link
Contributor Author

GretaD commented Jun 21, 2024 •
edited
Loading

Let's remove the screenshot because it will get outdated quicky and they contain sensitive information

the whole world should know that we have team calls.

@GretaD GretaD force-pushed the add/serach-docs branch 2 times, most recently from 5429fe3 to d1f6126 Compare July 24, 2024 15:09
ChristophWurst
ChristophWurst previously requested changes Jul 24, 2024
View reviewed changes
user_manual/groupware/mail.rst Outdated Show resolved Hide resolved
@GretaD GretaD requested a review from ChristophWurst July 24, 2024 15:25
@ChristophWurst
Copy link
Member

yes?

@ChristophWurst
Copy link
Member

https://github.com/nextcloud/documentation/actions/runs/10079255937/job/27866159958?pr=11863

Warning, treated as error:
/home/runner/actions-runner/_work/documentation/documentation/user_manual/groupware/mail.rst:30:image file not > readable: images/new-mail-account.png
make: *** [Makefile:65: html-lang-en] Error 2

@GretaD GretaD force-pushed the add/serach-docs branch from d1f6126 to eccca3f Compare July 24, 2024 15:53
@GretaD
Copy link
Contributor Author

GretaD commented Jul 24, 2024

https://github.com/nextcloud/documentation/actions/runs/10079255937/job/27866159958?pr=11863

Warning, treated as error:
/home/runner/actions-runner/_work/documentation/documentation/user_manual/groupware/mail.rst:30:image file not > readable: images/new-mail-account.png
make: *** [Makefile:65: html-lang-en] Error 2

sorry, i changed the files folder and forgot to change the path

kesselb
kesselb approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@GretaD GretaD merged commit d3773d0 into master Jul 25, 2024
12 checks passed
@GretaD GretaD deleted the add/serach-docs branch July 25, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@hamza221 hamza221 Awaiting requested review from hamza221

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

Assignees

@GretaD GretaD

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GretaD @kesselb @ChristophWurst