Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pathogen-repo-ci: Support a continue-on-error pass thru #40

Merged
merged 1 commit into from
May 9, 2023

Conversation

tsibley
Copy link
Member

@tsibley tsibley commented May 9, 2023

Allows calling workflows to succeed even if the job in this called workflow fails. This is a workaround for the calling working being unable to specify continue-on-error itself.¹

Related-to: nextstrain/docker-base#148

¹ https://docs.github.com/en/actions/using-workflows/reusing-workflows#supported-keywords-for-jobs-that-call-a-reusable-workflow

Testing

  • Checks pass

Allows calling workflows to succeed even if the job in this called
workflow fails.  This is a workaround for the calling working being
unable to specify continue-on-error itself.¹

Related-to: <nextstrain/docker-base#148>

¹ <https://docs.github.com/en/actions/using-workflows/reusing-workflows#supported-keywords-for-jobs-that-call-a-reusable-workflow>
@tsibley tsibley force-pushed the trs/pathogen-repo-ci/continue-on-error branch from 015ae86 to 9ecc493 Compare May 9, 2023 16:53
@tsibley
Copy link
Member Author

tsibley commented May 9, 2023

This works. The (intentionally) failed call of pathogen-repo-ci with continue-on-error: true doesn't tank the calling workflow:

image

and the UI also highlights the failures:

image

@tsibley tsibley merged commit 3f37fc6 into master May 9, 2023
@tsibley tsibley deleted the trs/pathogen-repo-ci/continue-on-error branch May 9, 2023 17:03
@victorlin
Copy link
Member

victorlin commented May 10, 2023

I wish the GitHub UI had some sort of indication on the commit level (2nd pic above, 1st arrow) that only continue-on-errors have failed. Mostly for this repo: since we expect test-pathogen-repo-ci-failure to always fail, the homepage will always show ❌ which needs an extra click to verify that it's just the one expected failure.

repo homepage

But, not a big deal. The ❌ should be useful on other repos.

@tsibley
Copy link
Member Author

tsibley commented May 10, 2023

Yeah. We could remove the test-pathogen-repo-ci-failure job from this repo's CI if it gets in the way too much. It's really only testing that the GitHub Actions behaviour works as expected. That is, I don't think we need to continually test that our continue-on-error: ${{ inputs.continue-on-error }} line remains in working order.

genehack added a commit that referenced this pull request May 15, 2024
Per Jover,

> This is testing the workaround for continue-on-error added in #40
> works as expected. Reading through that discussion again, @tsibley
> had noted that we can eventually remove the test.

The workaround has been working for a ~year now, so I think it's safe
to remove the test now!
genehack added a commit that referenced this pull request May 15, 2024
Per Jover,

> This is testing the workaround for continue-on-error added in #40
> works as expected. Reading through that discussion again, @tsibley
> had noted that we can eventually remove the test.

> The workaround has been working for a ~year now, so I think it's
> safe to remove the test now!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants