Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io/read_metadata: Fix dtype for the index column #1746

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

joverlee521
Copy link
Contributor

@joverlee521 joverlee521 commented Feb 7, 2025

Description of proposed changes

Ensure that the dtype for the index column is always a string so that it can be properly matched with ids even if they are numeric values.

Related issue(s)

Resolves #925

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

Ensure that the dtype for the index column is always a string so that
it can be properly matched with ids even if they are numeric values.
@joverlee521 joverlee521 force-pushed the fix-metadata-index-dtype branch from 3b7f395 to 489fa92 Compare February 7, 2025 00:42
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.06%. Comparing base (325b37b) to head (489fa92).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1746   +/-   ##
=======================================
  Coverage   73.06%   73.06%           
=======================================
  Files          79       79           
  Lines        8335     8335           
  Branches     1700     1700           
=======================================
  Hits         6090     6090           
  Misses       1958     1958           
  Partials      287      287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victorlin
Copy link
Member

Oh no, this bug has been around since 8161060, 1 year!

@joverlee521 joverlee521 merged commit 8920730 into master Feb 7, 2025
36 checks passed
@joverlee521 joverlee521 deleted the fix-metadata-index-dtype branch February 7, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

io.read_metadata does not always set index dtype as expected
2 participants