Skip to content

Commit

Permalink
Merge pull request #1942 from sagar-pathak/build-avatars-1441
Browse files Browse the repository at this point in the history
Support build avatars sourced from non-GitHub URLs #1441
  • Loading branch information
jameshadfield authored Feb 25, 2025
2 parents 8692b38 + e271252 commit ebd1a8d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
3 changes: 3 additions & 0 deletions src/actions/recomputeReduxState.js
Original file line number Diff line number Diff line change
Expand Up @@ -755,6 +755,9 @@ const createMetadataStateFromJSON = (json) => {
if (json.meta.build_url) {
metadata.buildUrl = json.meta.build_url;
}
if (json.meta.build_avatar) {
metadata.buildAvatar = json.meta.build_avatar;
}
if (json.meta.data_provenance) {
metadata.dataProvenance = json.meta.data_provenance;
}
Expand Down
10 changes: 7 additions & 3 deletions src/components/info/byline.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,13 @@ const AvatarImg = styled.img`
* which is a GitHub repo. The avatar image is fetched from GitHub (by the client).
*/
function renderAvatar(t, metadata) {
const repo = metadata.buildUrl;
if (typeof repo === 'string') {
const match = repo.match(/(https?:\/\/)?(www\.)?github.com\/([^/]+)/);
const { buildAvatar, buildUrl } = metadata;
if (typeof buildAvatar === 'string') {
return <AvatarImg alt="avatar" width="28" src={buildAvatar} />;
}

if (typeof buildUrl === 'string') {
const match = buildUrl.match(/(https?:\/\/)?(www\.)?github.com\/([^/]+)/);
if (match) {
return (
<AvatarImg alt="avatar" width="28" src={`https://github.com/${match[3]}.png?size=200`}/>
Expand Down

0 comments on commit ebd1a8d

Please sign in to comment.