-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install pango_aliasor #146
Conversation
Package maintained by myself to simplify aliasing and dealising of pango lineages Package is pure Python without dependencies and minimal size Source code: https://github.com/corneliusroemer/pango_aliasor See further discussion: https://bedfordlab.slack.com/archives/C01LCTT7JNN/p1683137801980639 Blocking for nextstrain/forecasts-ncov#39
33c2cba
to
dc55567
Compare
Anything holding this up? It's blocking for nextstrain/forecasts-ncov#39 |
Looks good to me, though I haven't done any updating to @tsibley or @victorlin: Okay to merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, though we had bigger picture discussions in Slack, i.e. maybe forecasts-ncov should maintain its own Docker image that extends nextstrain/base
with evofr
and pango_aliasor
instead of relying on them here.
This seems fine modulo what @victorlin said, but @corneliusroemer please do follow up sooner than later with the "Parallel addition to nextstrain/conda-base" todo. |
It's fully automatic. …but we're currently experiencing a CI breakage due to a change from this morning. A proposed fix is currently being tested. I plan to resolve it one way or another tomorrow morning. |
If we were to make more workflow specific images on top of docker-base, we could remove pango_aliasor again. All repos that were to use that package would then just have to make their own images - but that number isn't going to be much larger than 1 anyways. So I don't think that's blocking. |
Analogous to nextstrain/docker-base#146
Merging now that our CI and cache issues have been fixed. |
Package maintained by myself to simplify aliasing and dealising of pango lineages
Package is pure Python without dependencies and minimal size
Source code: https://github.com/corneliusroemer/pango_aliasor
See further discussion: https://bedfordlab.slack.com/archives/C01LCTT7JNN/p1683137801980639
Blocking for nextstrain/forecasts-ncov#39
TODO: