-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ambient install docs to specify Python version #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also modified the overall intent of the instructions slightly, so that they direct the user to set up a new Conda environment. The old instructions were oriented more towards adding Nextstrain to an existing Conda enviroment, which (IMO) seems like a less common scenario, and also one more likely to be undertaken by a more experienced user who will be able to adapt these instructions on the fly.
victorlin
reviewed
Apr 30, 2024
victorlin
requested changes
Apr 30, 2024
victorlin
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Updated the instructions in the ambient section to make it clear that a particular version of Python should be used. I also modified the overall intent of the instructions slightly, so that they direct the user to set up a new Conda environment. The old instructions were oriented more towards adding Nextstrain to an existing Conda enviroment, which (IMO) seems like a less common scenario, and also one more likely to be undertaken by a more experienced user who will be able to adapt these instructions on the fly; doing it this way also side-steps documenting how somebody would need to modify an existing Conda env with an unsupported version of Python.
Related issue(s)
#201
Checklist