Skip to content

Commit

Permalink
Update SLACK_CHANNELS envvar
Browse files Browse the repository at this point in the history
With the latest update to the new Slack APIs for uploading files,
the `SLACK_CHANNELS` envvar is required to be a channel id instead
of a channel name.¹ Rather than hard-coding the channel id in the
workflows, I've made them GH Action environment variables that are
shared across the Nexstrain org so they can be shared with the
ncov repo.²

¹ <nextstrain/ingest#47>
² <https://github.com/organizations/nextstrain/settings/variables/actions>
  • Loading branch information
joverlee521 committed Feb 25, 2025
1 parent 74bb91c commit 88492b7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/fetch-and-ingest-genbank-master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
CONFIG_OVERRIDES: ${{ needs.set_config_overrides.outputs.config_overrides }}
GITHUB_RUN_ID: ${{ github.run_id }}
NEXTSTRAIN_DOCKER_IMAGE: ${{ inputs.image || 'nextstrain/ncov-ingest' }}
SLACK_CHANNELS: ${{ inputs.trial_name && vars.TEST_SLACK_CHANNEL || 'ncov-genbank-updates' }}
SLACK_CHANNELS: ${{ inputs.trial_name && vars.TEST_SLACK_CHANNEL || vars.NCOV_GENBANK_SLACK_CHANNEL }}
run: |
nextstrain build \
--aws-batch \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/fetch-and-ingest-gisaid-master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
CONFIG_OVERRIDES: ${{ needs.set_config_overrides.outputs.config_overrides }}
GITHUB_RUN_ID: ${{ github.run_id }}
NEXTSTRAIN_DOCKER_IMAGE: ${{ inputs.image || 'nextstrain/ncov-ingest' }}
SLACK_CHANNELS: ${{ inputs.trial_name && vars.TEST_SLACK_CHANNEL || 'ncov-gisaid-updates' }}
SLACK_CHANNELS: ${{ inputs.trial_name && vars.TEST_SLACK_CHANNEL || vars.NCOV_GISAID_SLACK_CHANNEL }}
run: |
nextstrain build \
--aws-batch \
Expand Down

0 comments on commit 88492b7

Please sign in to comment.