Update SLACK_CHANNELS envvar
#492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latest update to the new Slack APIs for uploading files, the `SLACK_CHANNELS` envvar is required to be a channel id instead of a channel name.¹ Rather than hard-coding the channel id in the workflows, I've made them GH Action environment variables that are shared across the Nexstrain org so they can be shared with the ncov repo.² ¹ <nextstrain/ingest#47> ² <https://github.com/organizations/nextstrain/settings/variables/actions>
|
This can be merged before nextstrain/ingest#47 since the old |
8 tasks
genehack
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
With the latest update to the new Slack APIs for uploading files, the
SLACK_CHANNELSenvvar is required to be a channel id instead of a channel name.¹ Rather than hard-coding the channel id in the workflows, I've made them GH Action environment variables that are shared across the Nexstrain org so they can be shared with the ncov repo.²¹ nextstrain/ingest#47
² https://github.com/organizations/nextstrain/settings/variables/actions
Related issue(s)
Related to nextstrain/ingest#46
Checklist