Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cargo workspace config #1413

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Conversation

ivan-aksamentov
Copy link
Member

@ivan-aksamentov ivan-aksamentov commented Feb 12, 2024

https://doc.rust-lang.org/cargo/reference/workspaces.html

  • move cargo deps and package config fields from individual packages to the root Cargo.toml
  • move lint config to the root Cargo.toml (which allows to correctly apply lint rules to nextclade-web's build.rs step)

Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nextclade ✅ Ready (Inspect) Visit Preview Feb 14, 2024 1:03pm

Base automatically changed from chore/cleanup-4 to master February 13, 2024 04:58
@ivan-aksamentov ivan-aksamentov force-pushed the chore/cleanup-cargo-workspace branch from 5ada1bb to 39a82c2 Compare February 13, 2024 11:29
This improves clippy and compiler linting configuration, by  using `workspace.lints` and `lints` sections in the `Cargo.toml` files instead of (ab)using `rustflags` in the `.cargo/config.toml`.

This setup now correctly applies configuration to the `build.rs` step, which previously emitted a very large number of compiler warnings.

This also enables warnings for a few more compiler rules.
For the new rules added as a part of 339e8b6
@ivan-aksamentov ivan-aksamentov marked this pull request as ready for review February 16, 2024 03:53
@ivan-aksamentov ivan-aksamentov merged commit 0a1d3f5 into master Feb 16, 2024
20 checks passed
@ivan-aksamentov ivan-aksamentov deleted the chore/cleanup-cargo-workspace branch February 16, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant